Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fedora CoreOS support #5657

Merged
merged 7 commits into from
Mar 17, 2020
Merged

Fedora CoreOS support #5657

merged 7 commits into from
Mar 17, 2020

Conversation

spaced
Copy link
Contributor

@spaced spaced commented Feb 18, 2020 •
edited
Loading

docker and crio works, containerd not tested

What type of PR is this?
/kind feature

What this PR does / why we need it:
enable bootstrapping fedora coreos

Which issue(s) this PR fixes:

Fixes #5610

Special notes for your reviewer:
containerd not tested, is this required?

Does this PR introduce a user-facing change?:

Experimental feature for fedora coreos

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 18, 2020
@spaced spaced force-pushed the wip-fedora-coreos branch 6 times, most recently from 8291b6d to 9d022c0 Compare February 21, 2020 09:30
@Miouge1
Copy link
Contributor

Miouge1 commented Feb 26, 2020

The CI failures look unrelated to the PR.

It would be nice to have the default container engine working on Fedora Coreos so that it works with default kubespray settings.

@nemmeviu
Copy link

+1

@spaced spaced force-pushed the wip-fedora-coreos branch from 9d022c0 to 8434887 Compare March 15, 2020 21:07
@spaced
Copy link
Contributor Author

spaced commented Mar 15, 2020

docker works out of the box, tested with latest fedora 31.20200223.3.0 using kvm
https://gist.github.com/spaced/81b4a22f323e93839a76982aa585c76a
will add some documentation and remove the WIP
would be nice to setup a CI but i think this is to early until we remove experimental

@spaced spaced force-pushed the wip-fedora-coreos branch 3 times, most recently from db3adb4 to 45ff90f Compare March 15, 2020 21:32
@Miouge1
Copy link
Contributor

Miouge1 commented Mar 16, 2020

@spaced we did some work last week to improve CI, can you rebase on latest master, hopefully we get a green CI?

spaced added 5 commits March 16, 2020 14:31
@spaced
fedora coreos support
bbaef1e 
- bootstrap and new fact for
@spaced
fedora coreos support
e30ee0a 
- fix bootstrap condition
@spaced
fedora coreos support
f0513d6 
- allow customize packages for fedora coreos bootstrap
@spaced
fedora coreos support
7bb1acf 
- prevent install ptyhon3 and epel via dnf for fedora coreos
@spaced
fedora coreos support
375332c 
- handle all ostree like os in same way
@spaced spaced force-pushed the wip-fedora-coreos branch from 45ff90f to 375332c Compare March 16, 2020 13:45
@spaced
fedora coreos support
ddfc5b7 
- handle all ostree like os in same way for crio
@spaced spaced changed the title WIP: fedora coreos support Fedora CoreOS support Mar 16, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2020
@spaced spaced force-pushed the wip-fedora-coreos branch from ec7dfa9 to fdc16ea Compare March 16, 2020 20:56
@spaced spaced closed this Mar 16, 2020
@spaced spaced reopened this Mar 16, 2020
@spaced spaced force-pushed the wip-fedora-coreos branch from fdc16ea to 4ddda1a Compare March 16, 2020 21:11
@spaced
fedora coreos support
e31d69f 
- add fcos documentations
@spaced spaced force-pushed the wip-fedora-coreos branch from 4ddda1a to e31d69f Compare March 16, 2020 21:14
@mattymo
Copy link
Contributor

mattymo commented Mar 17, 2020

We need to add CI for Fedora CoreOS, but this will be done in a separate patch. Let's accept this as-is for now.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, spaced

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 876d4de into kubernetes-sigs:master Mar 17, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 9, 2020
@spaced @LuckySB
Fedora CoreOS support (kubernetes-sigs#5657)
7a320c0 
* fedora coreos support
- bootstrap and new fact for

* fedora coreos support
- fix bootstrap condition

* fedora coreos support
- allow customize packages for fedora coreos bootstrap

* fedora coreos support
- prevent install ptyhon3 and epel via dnf for fedora coreos

* fedora coreos support
- handle all ostree like os in same way

* fedora coreos support
- handle all ostree like os in same way for crio

* fedora coreos support
- add fcos documentations
@Miouge1 Miouge1 mentioned this pull request Apr 23, 2020
Closed
@floryut floryut mentioned this pull request Aug 4, 2020
Closed
@mgvazquez
Copy link

Hi, someone know if this PR keep in mind RHEL CoreOS, or it's only works for Fedora CoreOS?

@champtar
Copy link
Contributor

RHEL CoreOS only exists as node of an OpenShift cluster if I understand correctly

@spaced spaced deleted the wip-fedora-coreos branch June 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmsten holmsten Awaiting requested review from holmsten

@LuckySB LuckySB Awaiting requested review from LuckySB

Assignees

@mattymo mattymo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Fedora CoreOS and RedHat CoreOS
7 participants
@spaced @Miouge1 @nemmeviu @mattymo @k8s-ci-robot @mgvazquez @champtar