-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flatcar #5607
Add flatcar #5607
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @sylflo! |
/check-cla |
I did not remove all the check with coreOS |
/retest |
@sylflo: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Miouge1 could it be possible to relaunch the test please ? Or I don't quite understand if I did anything wrong since the test are failing with a timeout https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/428891428 |
Yes, I restarted that job, the error looked unrelated to your patch. |
@Miouge1 I am sorry to bother you again, now it's this job https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/428891441 which fails with a timeout :/ |
/assign @Miouge1 |
@sylflo can you rebase on latest master? that should solve the |
It's way better :). I am just a bit surprised that this test does not pass https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/439743605. Apparently it's a problem with ssh, maybe it's this file |
@sylflo sometimes SSH doesn't answer fast enough in CI, a retry got the job green 🤷♂ Thank you for the contribution! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miouge1, sylflo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…role (#5607) (#5818) Co-authored-by: Sylvain Chateau <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for Flatcar
Which issue(s) this PR fixes:
Fixes #5375
Special notes for your reviewer:
Does this PR introduce a user-facing change?: