Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatcar #5607

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add flatcar #5607

merged 1 commit into from
Feb 18, 2020

Conversation

sylflo
Copy link
Contributor

@sylflo sylflo commented Feb 6, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add support for Flatcar

Which issue(s) this PR fixes:

Fixes #5375

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 6, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @sylflo!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2020
@sylflo
Copy link
Contributor Author

sylflo commented Feb 6, 2020

/check-cla

@sylflo
Copy link
Contributor Author

sylflo commented Feb 7, 2020

I did not remove all the check with coreOS "Coreos", "Container Linux by CoreOS". But maybe it should be done in another PR as CoreOS will be EOL by the end of May

@sylflo
Copy link
Contributor Author

sylflo commented Feb 7, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@sylflo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 7, 2020
@sylflo sylflo changed the title [WIP] Add flatcar Add flatcar Feb 7, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2020
@sylflo
Copy link
Contributor Author

sylflo commented Feb 7, 2020

@Miouge1 could it be possible to relaunch the test please ? Or I don't quite understand if I did anything wrong since the test are failing with a timeout https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/428891428

@Miouge1
Copy link
Contributor

Miouge1 commented Feb 7, 2020

Yes, I restarted that job, the error looked unrelated to your patch.

@sylflo
Copy link
Contributor Author

sylflo commented Feb 7, 2020

@Miouge1 I am sorry to bother you again, now it's this job https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/428891441 which fails with a timeout :/

@sylflo
Copy link
Contributor Author

sylflo commented Feb 11, 2020

/assign @Miouge1

@Miouge1
Copy link
Contributor

Miouge1 commented Feb 17, 2020

@sylflo can you rebase on latest master? that should solve the RECOVER_CONTROL_PLANE_TEST error.

@sylflo
Copy link
Contributor Author

sylflo commented Feb 17, 2020

@Miouge1

It's way better :). I am just a bit surprised that this test does not pass https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/439743605.

Apparently it's a problem with ssh, maybe it's this file roles/download/tasks/prep_download.yml but that would be a bit weird if that's the problem no ?
Moreover this job passed with no problem before I rebased https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/428891430

@Miouge1
Copy link
Contributor

Miouge1 commented Feb 18, 2020

@sylflo sometimes SSH doesn't answer fast enough in CI, a retry got the job green 🤷‍♂

Thank you for the contribution!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, sylflo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0ca7aa1 into kubernetes-sigs:master Feb 18, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Mar 7, 2020
verwilst pushed a commit to verwilst/kubespray that referenced this pull request Mar 24, 2020
k8s-ci-robot pushed a commit that referenced this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatcar Support
3 participants