Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external zones in nodelocaldns configuration #5591

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Add external zones in nodelocaldns configuration #5591

merged 1 commit into from
Mar 14, 2020

Conversation

bozzo
Copy link
Contributor

@bozzo bozzo commented Jan 29, 2020 •
edited by Miouge1
Loading

Allows to configure additionnal zone for domains not resolved by upstream_dns_servers.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allows to configure additionnal zones in nodelocaldns configuration for domains not resolved by upstream_dns_servers.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Based on PR #5280 for Coredns

Does this PR introduce a user-facing change?:

Allows to configure additionnal zones on `nodelocaldns` for domains not resolved by `upstream_dns_servers`.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2020
@bozzo bozzo force-pushed the master branch 2 times, most recently from 700d925 to 95e3361 Compare January 29, 2020 13:12
@bozzo
Copy link
Contributor Author

bozzo commented Jan 29, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@bozzo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bozzo
Copy link
Contributor Author

bozzo commented Jan 29, 2020

/assign @riverzhang

huxcrux
huxcrux reviewed Feb 24, 2020
View reviewed changes
Copy link

@huxcrux huxcrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Miouge1
Copy link
Contributor

Miouge1 commented Feb 26, 2020

@woopstar what do you think about this? It looks right down your alley.

@bozzo
Add external zones in nodelocaldns configuration
2c55f9a 
Allows to configure additionnal zone for domains not resolved by `upstream_dns_servers`.
@bozzo bozzo closed this Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2020
@bozzo bozzo reopened this Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 5, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Mar 14, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bozzo, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit d69db34 into kubernetes-sigs:master Mar 14, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Mar 14, 2020
@bozzo @LuckySB
Add external zones in nodelocaldns configuration (kubernetes-sigs#5591)
4fc559c 
Allows to configure additionnal zone for domains not resolved by `upstream_dns_servers`.
@Miouge1 Miouge1 mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huxcrux huxcrux huxcrux left review comments

@holmsten holmsten Awaiting requested review from holmsten

@mattymo mattymo Awaiting requested review from mattymo

Assignees

@Miouge1 Miouge1

@riverzhang riverzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bozzo @k8s-ci-robot @Miouge1 @huxcrux @riverzhang