Add proxy support to containerd, improves no_proxy #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne Champetier <[email protected]>
…no_proxy CIDR notation in no_proxy is supported by a lot of programs/languages, including go: golang/go#16704 Without that containerd cannot talk the the API server (kube_apiserver_ip), but it should not go through an external proxy for the nodes/pods/services Signed-off-by: Etienne Champetier <[email protected]>
k8s-ci-robot
added
kind/bug
|
We don't have an easy way to test this, but it looks good to me. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: champtar, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Feb 6, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: Add LuckySB as an approver (kubernetes-sigs#5584) Add CentOS 8 image for testing (kubernetes-sigs#5589) Fix typo in Multus plugin. (kubernetes-sigs#5568) Add proxy support to containerd, improves no_proxy (kubernetes-sigs#5583) Remove stale legacy yum docker repo /etc/yum.repos.d/docker.repo (kubernetes-sigs#5569)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Mar 6, 2020
) * containerd: add proxy support Signed-off-by: Etienne Champetier <[email protected]> * kubespray-defaults: add kube_service_addresses / kube_pods_subnet to no_proxy CIDR notation in no_proxy is supported by a lot of programs/languages, including go: golang/go#16704 Without that containerd cannot talk the the API server (kube_apiserver_ip), but it should not go through an external proxy for the nodes/pods/services Signed-off-by: Etienne Champetier <[email protected]>
champtar
added a commit
to champtar/kubespray
that referenced
this pull request
Mar 25, 2020
) * containerd: add proxy support Signed-off-by: Etienne Champetier <[email protected]> * kubespray-defaults: add kube_service_addresses / kube_pods_subnet to no_proxy CIDR notation in no_proxy is supported by a lot of programs/languages, including go: golang/go#16704 Without that containerd cannot talk the the API server (kube_apiserver_ip), but it should not go through an external proxy for the nodes/pods/services Signed-off-by: Etienne Champetier <[email protected]> (cherry picked from commit 9f2dd09)
champtar
added a commit
to champtar/kubespray
that referenced
this pull request
Mar 25, 2020
) * containerd: add proxy support Signed-off-by: Etienne Champetier <[email protected]> * kubespray-defaults: add kube_service_addresses / kube_pods_subnet to no_proxy CIDR notation in no_proxy is supported by a lot of programs/languages, including go: golang/go#16704 Without that containerd cannot talk the the API server (kube_apiserver_ip), but it should not go through an external proxy for the nodes/pods/services Signed-off-by: Etienne Champetier <[email protected]> (cherry picked from commit 9f2dd09)
k8s-ci-robot
pushed a commit
that referenced
this pull request
Mar 27, 2020
* containerd: add proxy support Signed-off-by: Etienne Champetier <[email protected]> * kubespray-defaults: add kube_service_addresses / kube_pods_subnet to no_proxy CIDR notation in no_proxy is supported by a lot of programs/languages, including go: golang/go#16704 Without that containerd cannot talk the the API server (kube_apiserver_ip), but it should not go through an external proxy for the nodes/pods/services Signed-off-by: Etienne Champetier <[email protected]> (cherry picked from commit 9f2dd09)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR add a systemd drop-in config to containerd to setup proxy environment variables
Which issue(s) this PR fixes:
Fixes _
Special notes for your reviewer:
Does this PR introduce a user-facing change?: