Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set helm 3.0 as default #5503

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Conversation

verwilst
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
This changes the default helm version to v3.0.

Does this PR introduce a user-facing change?:

action required!

Users will have to be made aware how they can migrate their existing v2 objects to v3 (https://helm.sh/docs/topics/v2_v3_migration/ and https://github.com/helm/helm-2to3), and be told the following:

  • Upgraders will still have Tiller running, so only when they use the helm binary on their api/master nodes will they have to do something. I think a lot of people use local helm binaries as well, which won't be impacted.
  • New installs won't have a Tiller, so can only use Helm v3. They either have to change helm_version or be made aware of the namespaced scope of v3.

Upgrading to Helm v3

This release installs Helm v3 by default. You can stop this from happening by setting `helm_version = 'v2.16.1'` for example in `group_vars/k8s-cluster/addons.yml`.

When this is an upgrade of an existing cluster, follow the steps outlined by https://helm.sh/docs/topics/v2_v3_migration/ and https://github.com/helm/helm-2to3 afterwards to convert your Helm v2 releases to v3.

After the upgrade to Helm v3, Tiller will still be running on your cluster, but the `helm` binary on the api/master nodes will be replaced by a v3 counterpart. You won't be able to access/modify/upgrade your Helm v2 releases by using the default 'helm' binary on those nodes. Please manually download a Helm v2 binary on your workstation to modify existing v2 releases, or use the 2to3 plugin to convert everything to v3.

You will have to remove Tiller from your cluster manually ( or through the 2to3 plugin cleanup action) after everything has been migrated to v3.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 30, 2019
@Miouge1
Copy link
Contributor

Miouge1 commented Jan 14, 2020

@verwilst brilliant!

Looks good to me. @mirwan any additional feedback on this (I think you were involved in the previous Helm 3 discussions) ?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2020
@mirwan
Copy link
Contributor

mirwan commented Jan 16, 2020

@Miouge1 Thx for asking. It's fine with me of course

@verwilst
Copy link
Contributor Author

Can we sign the deal with an approval? ;-)

@holmsten
Copy link
Contributor

Looks good, but v3.0.3 is released now. Can you update while we're waiting for an approver? :)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2020
@holmsten
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2020
@Atoms Atoms added the release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. label Feb 12, 2020
@Atoms
Copy link
Member

Atoms commented Feb 12, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Atoms, verwilst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Feb 13, 2020

I'm rebasing this on latest master, that should fix the error in CI.

@Miouge1 Miouge1 added this to the 2.13 milestone Feb 13, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Feb 13, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 287421e into kubernetes-sigs:master Feb 13, 2020
@Miouge1 Miouge1 mentioned this pull request Feb 13, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Mar 6, 2020
* set helm 3.0 as default

* remove trainling space in vars.yml

* switched to helm 3.0.3
@verwilst verwilst deleted the default-to-helm3 branch June 9, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants