Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS ALB Ingress Controller #5489

Merged
merged 5 commits into from
Mar 16, 2020
Merged

Add AWS ALB Ingress Controller #5489

merged 5 commits into from
Mar 16, 2020

Conversation

msh111
Copy link
Contributor

@msh111 msh111 commented Dec 20, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add AWS ALB Ingress Controller as add-on application

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Tested on my AWS account

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @msh111!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2019
@msh111
Copy link
Contributor Author

msh111 commented Dec 25, 2019

fixed CLA
/assign @woopstar

Miouge1
Miouge1 suggested changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@Miouge1 Miouge1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msh111 thank you for your contribution, it looks like you need to rebase on latest master to resolve the CI errors.

Also can we consider an OWNERS file for this role?
Also you need to refresh the CLA with the bot.

@M00nF1sh and @bigkraig any input on this?

@msh111
Copy link
Contributor Author

msh111 commented Jan 12, 2020

/check-cla

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 12, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 12, 2020
@msh111 msh111 requested a review from Miouge1 January 12, 2020 10:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 12, 2020
@msh111
Copy link
Contributor Author

msh111 commented Jan 25, 2020

@msh111 thank you for your contribution, it looks like you need to rebase on latest master to resolve the CI errors.

Also can we consider an OWNERS file for this role?
Also you need to refresh the CLA with the bot.

@M00nF1sh and @bigkraig any input on this?

@Miouge1 , Fixed as requested
Please review

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2020
@LuckySB
Copy link
Contributor

LuckySB commented Feb 19, 2020

I think it should be inside kubernetes-apps/ingress_controller metarole

@Miouge1
Copy link
Contributor

Miouge1 commented Mar 14, 2020

@msh111 can you look into moving this into roles/kubernetes-apps/ingress_controller ?

@msh111
Copy link
Contributor Author

msh111 commented Mar 15, 2020

@msh111 can you look into moving this into roles/kubernetes-apps/ingress_controller ?

done

@Miouge1
Copy link
Contributor

Miouge1 commented Mar 16, 2020

Looks good to me, thank you @msh111 !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, msh111

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 29128eb into kubernetes-sigs:master Mar 16, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 9, 2020
@msh111 @LuckySB
Add AWS ALB Ingress Controller (kubernetes-sigs#5489)
a8eb0b2 
* Add AWS ALB Ingress Controller Ansible role

* remove trailing spaces

* update owners

* ALB ingress: update rbac clusterrole and remove role

* Move alb-ingress role to roles/kubernetes-apps/ingress_controller folder
@Miouge1 Miouge1 mentioned this pull request Apr 23, 2020
Closed
@oomichi oomichi mentioned this pull request Jan 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmsten holmsten Awaiting requested review from holmsten

@Miouge1 Miouge1 Awaiting requested review from Miouge1

Assignees

@woopstar woopstar

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msh111 @k8s-ci-robot @LuckySB @Miouge1 @woopstar