-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add az_list_node variable to specify different AZs for kubelets #5413
add az_list_node variable to specify different AZs for kubelets #5413
Conversation
update from upstream
pull from upstream
update to upstream master
/assign @holmsten |
Also fixes some deprecation warnings for TF 0.12 |
I would say that this is a user facing change? Most Openstack installation have custom AZs set meaning this might break clusters for users that doesn't read the code. This should probably be added to the Openstack terraform documentation as well (https://github.com/kubernetes-sigs/kubespray/blob/master/contrib/terraform/openstack/README.md) |
Can we make this backwards compatible? Something like |
@Miouge1 @bl0m1 Then there could be a conditional (ternary) expression, something like
Would that be a good way? |
merge from upstream master
Looks good :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: holmsten, rptaylor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rnetes-sigs#5413) * rebase and add az_list_node variable to specify different AZs for kubelets * fix missing variable name change
What type of PR is this?
What this PR does / why we need it:
Since kubelet nodes can be considered ephemeral/disposable , different availability considerations may apply than for master nodes. Accordingly, on Openstack users may wish to use different AZs or different balancing across AZs for kubelet nodes than for master nodes. This PR adds a TF variable az_list_node which is exactly like az_list, but it applies only for the k8s node type. The default value is the same, so there is no change in behaviour unless users choose to modify the variable.
This provides finer control over placement of different types of nodes on Openstack.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No