Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #5160 #5171

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Fix for issue #5160 #5171

merged 1 commit into from
Sep 17, 2019

Conversation

holmesb
Copy link
Contributor

@holmesb holmesb commented Sep 13, 2019

@k8s-ci-robot
Copy link
Contributor

Welcome @holmesb!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2019
@mjlshen
Copy link
Contributor

mjlshen commented Sep 13, 2019

@holmesb Thanks for this! Actually I think only the first gather_facts needs to be changed to yes because it's the reset role that has a dependency for gathering the ansible_os_family fact, while neither the remove-node nor the kubespray-defaults role have that as far as I understand.

@riverzhang
Copy link
Contributor

@holmesb Please sign the CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 17, 2019
@riverzhang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2019
@riverzhang
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: holmesb, riverzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 46f6c09 into kubernetes-sigs:master Sep 17, 2019
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 18, 2019
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
b51fc4e 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add support for k8s v1.14.6 (kubernetes-sigs#5182)
  Parameterize gcr, quay, and docker image repo defines (kubernetes-sigs#5146)
  use hyperkubeimage to run controlplane containers (kubernetes-sigs#5178)
  Update main.yml (kubernetes-sigs#5166)
  Fixes issue kubernetes-sigs#5160 (kubernetes-sigs#5171)
  Use more native way to update kubeconfigs using kubeadm (kubernetes-sigs#5165)
  Fix macro on local_volume_provisioner (kubernetes-sigs#5168)
  Move cri_socket var to kubespray-defaults (kubernetes-sigs#5149)
  Add support for k8s v1.16.0-beta.2 (kubernetes-sigs#5148)
  Fix ansible task titles (kubernetes-sigs#5154)
  Adjust endpoints for kube-proxy,controller,scheduler to proper ip (kubernetes-sigs#5150)
  Documenting Terraform variable `az_list` explicitly (kubernetes-sigs#5132)
  Make haproxy/nginx client timeout configurable (kubernetes-sigs#5140)
  print hostnames (kubernetes-sigs#5110)
  Cleanup: fix typo in doc (kubernetes-sigs#5105)
  Use python3-libselinux on RHEL8/Centos8 (kubernetes-sigs#5127)
minshenglin added a commit to inwinstack/kubespray that referenced this pull request Nov 7, 2019
@minshenglin
fix remove node failed
71fcb3f 
based on kubernetes-sigs#5171
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Dec 8, 2019
@holmesb @LuckySB
Fixes issue kubernetes-sigs#5160 (kubernetes-sigs#5171)
5f2d5e7
ssup2 added a commit to ssup2/kubespray that referenced this pull request Dec 12, 2019
@ssup2
Disable unused gather_facts in remove-node.yml
13f06f2 
kubernetes-sigs#5171 (comment)

As mention @mjlshen, last gather_facts don't need to "yes"
@ssup2 ssup2 mentioned this pull request Dec 12, 2019
Closed
ssup2 added a commit to ssup2/kubespray that referenced this pull request Dec 12, 2019
@ssup2
Disable unused gather_facts in remove-node.yml
351ac2d 
kubernetes-sigs#5171 (comment)

Only 3rd gather_facts needs to be "yes" in remove-node.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmsten holmsten Awaiting requested review from holmsten

@Miouge1 Miouge1 Awaiting requested review from Miouge1

Assignees

@riverzhang riverzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holmesb @k8s-ci-robot @mjlshen @riverzhang