Use combine to set calico-rr cluster id reliably #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattymo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
ci check this |
mattymo
force-pushed
the
calico_rr_idempotent
branch
from
df261fe to
3e46e01
Compare
mattymo
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
mattymo
force-pushed
the
calico_rr_idempotent
branch
from
3e46e01 to
decf136
Compare
k8s-ci-robot
added
size/M
mattymo
force-pushed
the
calico_rr_idempotent
branch
from
decf136 to
fc119df
Compare
k8s-ci-robot
added
size/S
mattymo
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
AlexeyKasatkin
approved these changes
Aug 27, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Aug 28, 2019
* 'master' of https://github.com/kubernetes-sigs/kubespray: Parse calico nodes as json (kubernetes-sigs#5114) remove unimplemented custom_flags vars, document the extra_args vars (issue 4352) (kubernetes-sigs#5108) Allow calico settings to be modified (kubernetes-sigs#5101) Added CRI-O support for ubuntu (kubernetes-sigs#4629) Replace fetch with synchronize due to memory error (kubernetes-sigs#5084) Use raw module for bootstrap-debian.yml (kubernetes-sigs#5061) Update CRI-O in CentOS (kubernetes-sigs#4582) Add localhost to ansible.limit. (kubernetes-sigs#5037) fix bug: run Copy image to ansible host cache on download_delegate host (kubernetes-sigs#5094)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Dec 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method was unreliable due to random ordering of calico node object