Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubespray-defaults in remove-node role #4946

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

Timoses
Copy link
Contributor

@Timoses Timoses commented Jul 4, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Without this PR the playbook remove-node is unable to execute the tasks in roles/remove-node/{pre/post}-remove/tasks/main.yml as bin_dir is undefined.

TASK [remove-node/pre-remove : cordon-node | Mark all nodes as unschedulable before drain] ***************************************************
task path: /home/funke_t1/code/ansible/ansible/plays/kubernetes/kubespray/roles/remove-node/pre-remove/tasks/main.yml:2
fatal: [kubernetes-dev-6.mgmt.hss.int]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'bin_dir' is undefined\n\nThe error appears to be in '/home/funke_t1/code/ansible/ansible/plays/kubernetes/kubespray/roles/remove-node/pre-remove/tasks
/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: cordon-node | Mark all nodes as unschedulable before drain\n  ^ here\n"}
...ignoring

TASK [remove-node/pre-remove : remove-node | Drain node except daemonsets resource] **********************************************************
task path: /home/funke_t1/code/ansible/ansible/plays/kubernetes/kubespray/roles/remove-node/pre-remove/tasks/main.yml:12
fatal: [kubernetes-dev-6.mgmt.hss.int]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'bin_dir' is undefined\n\nThe error appears to be in '/home/funke_t1/code/ansible/ansible/plays/kubernetes/kubespray/roles/remove-node/pre-remove/tasks
/main.yml': line 12, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: remove-node | Drain node except daemonsets resource\n  ^ here\n"}
...ignoring
TASK [remove-node/post-remove : Delete node] *************************************************************************************************
task path: /home/funke_t1/code/ansible/ansible/plays/kubernetes/kubespray/roles/remove-node/post-remove/tasks/main.yml:3
fatal: [kubernetes-dev-6.mgmt.hss.int]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'bin_dir' is undefined\n\nThe error appears to be in '/home/funke_t1/code/ansible/ansible/plays/kubernetes/kubespray/roles/remove-node/post-remove/tasks/main.yml': line 3, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Delete node\n  ^ here\n"}
...ignoring

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Tested remove-node.yml playbook with the changes and it successfully runs with correct bin_dir specified.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 4, 2019
@k8s-ci-robot k8s-ci-robot requested a review from holmsten July 4, 2019 08:46
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2019
@k8s-ci-robot k8s-ci-robot requested a review from Miouge1 July 4, 2019 08:46
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2019
@riverzhang
Copy link
Contributor

ci check this
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: riverzhang, Timoses

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 53032a6 into kubernetes-sigs:master Jul 5, 2019
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants