-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ansible 2.7.8 #4535
Upgrade to Ansible 2.7.8 #4535
Conversation
ci check this |
/lgtm |
You need to upgrade the version in README and in pre checks too |
Good point @woopstar I forgot about that. It should be fixed in the latest commit. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miouge1, woopstar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR has the unfortunate site effect, that the version of Ansible in Debian-Buster is not sufficient: It is only Requiring an updated version of Ansible for some required functionality is IMHO okay, but for security? IMHO please not. |
Security is first thing why someone should update some software, if Debian-Buster is backporting some CVE to older versions we cannot work with that, as we see now latest ansible ion 2.7.x is actually: v2.7.12 so reverting to allow 2.7.7 would be insane. if we revert to 2.7.7 it's only debian which has this version. and other OS is vulnerable cause they don't backport CVE, but release new version. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ansible fetch module before versions 2.5.15, 2.6.14, 2.7.8 has a path traversal vulnerability which allows copying and overwriting files outside of the specified destination in the local ansible controller host, by not restricting an absolute path.
See https://nvd.nist.gov/vuln/detail/CVE-2019-3828
Special notes for your reviewer:
Does this PR introduce a user-facing change?: