Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ansible 2.7.8 #4535

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Apr 16, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Ansible fetch module before versions 2.5.15, 2.6.14, 2.7.8 has a path traversal vulnerability which allows copying and overwriting files outside of the specified destination in the local ansible controller host, by not restricting an absolute path.

See https://nvd.nist.gov/vuln/detail/CVE-2019-3828

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2019
@k8s-ci-robot k8s-ci-robot requested review from ant31 and Atoms April 16, 2019 07:05
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2019
@Atoms
Copy link
Member

Atoms commented Apr 16, 2019

ci check this

@Atoms
Copy link
Member

Atoms commented Apr 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@woopstar
Copy link
Member

You need to upgrade the version in README and in pre checks too

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2019
@Miouge1
Copy link
Contributor Author

Miouge1 commented Apr 16, 2019

Good point @woopstar I forgot about that. It should be fixed in the latest commit.

@woopstar woopstar closed this Apr 17, 2019
@woopstar woopstar reopened this Apr 17, 2019
@woopstar woopstar added this to the 2.10 milestone Apr 17, 2019
@woopstar
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit f69b5f7 into kubernetes-sigs:master Apr 17, 2019
@pmhahn
Copy link

pmhahn commented Aug 7, 2019

This PR has the unfortunate site effect, that the version of Ansible in Debian-Buster is not sufficient: It is only 2.7.7 but with the fix for CVE-2019-3828 applied on top: https://metadata.ftp-master.debian.org/changelogs//main/a/ansible/ansible_2.7.7+dfsg-1_changelog

Requiring an updated version of Ansible for some required functionality is IMHO okay, but for security? IMHO please not.
Can this PR be reverted?

@Atoms
Copy link
Member

Atoms commented Aug 7, 2019

Security is first thing why someone should update some software, if Debian-Buster is backporting some CVE to older versions we cannot work with that, as we see now latest ansible ion 2.7.x is actually: v2.7.12 so reverting to allow 2.7.7 would be insane. if we revert to 2.7.7 it's only debian which has this version. and other OS is vulnerable cause they don't backport CVE, but release new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants