Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable become for localhost #4287

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Disable become for localhost #4287

merged 1 commit into from
Feb 26, 2019

Conversation

andjelx
Copy link
Contributor

@andjelx andjelx commented Feb 21, 2019

Disable become for localhost as when using -b flag it tries to invoke sudo on locahost

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 21, 2019
@andjelx
Copy link
Contributor Author

andjelx commented Feb 21, 2019

@mirwan @Miouge1 seems there are some rights missing in CI pipeline :(

$ /bin/sh scripts/premoderator.sh
User does not have permissions to start CI run
ERROR: Job failed: command terminated with exit code

@mirwan
Copy link
Contributor

mirwan commented Feb 21, 2019

ci check this

Miouge1
Miouge1 approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@Miouge1 Miouge1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019
@andjelx
Copy link
Contributor Author

andjelx commented Feb 25, 2019

Dear @mirwan @Miouge1 could you please check when you'd have a time as seems approved label is missing. Much appreciated.

@Miouge1
Copy link
Contributor

Miouge1 commented Feb 25, 2019

@andjelx as you can see in OWNERS_ALIASES we are just reviewers and there is another set of people with permissions to set approved labels.

@andjelx
Copy link
Contributor Author

andjelx commented Feb 25, 2019

@Miouge1 My bad, sorry.

@riverzhang
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andjelx, riverzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit c66e9a6 into kubernetes-sigs:master Feb 26, 2019
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 4, 2019
@andjelx @LuckySB
Disable become for localhost (kubernetes-sigs#4287)
751d232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirwan mirwan mirwan approved these changes

@Miouge1 Miouge1 Miouge1 approved these changes

Assignees

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andjelx @mirwan @Miouge1 @riverzhang @k8s-ci-robot