hostnameOverride on a per-node basis in kube-proxy configuration with kubeadm #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
ci check this |
|
@mirwan Thanks! This bug has existed for a long time. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: riverzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mirwan
force-pushed
the
hostnameoverride_externaltrafficpolicy_local
branch
from
977f41b to
b380350
Compare
|
@riverzhang a lgtm as well please? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
woopstar
reviewed
Nov 14, 2018
| @@ -180,7 +180,6 @@ conntrack: | |||
| tcpEstablishedTimeout: 24h0m0s | |||
| enableProfiling: false | |||
| healthzBindAddress: 0.0.0.0:10256 | |||
| hostnameOverride: {{ inventory_hostname }} | |||
There was a problem hiding this comment.
If you remove this, then it wont be set unless you have win nodes?
There was a problem hiding this comment.
@woopstar Actually I was a bit astonished by the path of the role but couldn't see any restriction so I guess it will be set when kubeadm is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes PR #3612 (by addressing the issue described here https://kubernetes.io/docs/setup/independent/troubleshooting-kubeadm/#services-with-externaltrafficpolicy-local-are-not-reachable) and thus fixes #3610.