Remove Vault #3684
Merged
Remove Vault #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ant31
force-pushed
the
deprecate_vault
branch
from
c6fc8db to
1981d3f
Compare
k8s-ci-robot
removed
the
lgtm
|
ci check this @Atoms that was a quick review :) |
ant31
force-pushed
the
deprecate_vault
branch
from
1981d3f to
7ccf103
Compare
Atoms
reviewed
Nov 9, 2018
Atoms
reviewed
Nov 9, 2018
Atoms
reviewed
Nov 9, 2018
Atoms
reviewed
Nov 9, 2018
| @@ -43,42 +43,39 @@ | |||
| 8. Copy and modify configs from kubespray `group_vars` folder to corresponging `group_vars` folder in your existent project. | |||
| You could rename *all.yml* config to something else, i.e. *kubespray.yml* and create corresponding group in your inventory file, which will include all hosts groups related to kubernetes setup. | |||
|
|
|||
| 9. Modify your ansible inventory file by adding mapping of your existent groups (if any) to kubespray naming. | |||
| 9. Modify your ansible inventory file by adding mapping of your existent groups (if any) to kubespray naming. | |||
| For example: | |||
| ``` | |||
| ... | |||
| #Kargo groups: | |||
Atoms
reviewed
Nov 9, 2018
Atoms
reviewed
Nov 9, 2018
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chadswen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
daohoangson
added a commit
to daohoangson/kubespray
that referenced
this pull request
Dec 8, 2018
ant31
pushed a commit
that referenced
this pull request
Dec 9, 2018
spisarski
pushed a commit
to cablelabs/kubespray
that referenced
this pull request
Feb 11, 2019
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3508 As agreed with the maintainers/owners
fixes #3682