Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs-provisioner: Upgrade to 1.1.0-k8s1.10 #2974

Conversation

hswong3i
Copy link
Contributor

@hswong3i hswong3i commented Jul 7, 2018

Upstream Changes:

Our Changes:

Upstream Changes:

-   Update CEPH_VERSION to mimic (kubernetes-retired/external-storage#841)

Our Changes:

-   Using image from official repo which contain latest changes (https://quay.io/repository/external_storage/cephfs-provisioner)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2018
@riverzhang
Copy link
Contributor

ci check this

@riverzhang
Copy link
Contributor

riverzhang commented Jul 8, 2018

@hswong3i Why didn't you consider adding rbd-provisioner to Kubespray?

Copy link
Contributor

@riverzhang riverzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riverzhang riverzhang merged commit 810596c into kubernetes-sigs:master Jul 9, 2018
@hswong3i
Copy link
Contributor Author

hswong3i commented Jul 9, 2018

@hswong3i Why didn't you consider adding rbd-provisioner to Kubespray?

@riverzhang Because CephFS support RWX, where RBD only support RWO...

In my use cases for Drupal hosting, multiple Apache and PHP-FPM pods mounting single shared RWX /var/www (i.e. CephFS good for this), where individual MariaDB mount its own RWO /var/lib/mysql and form a multi-master cluster; therefore implementing RBD support is just half-way for me ;-)

@hswong3i hswong3i deleted the cephfs-provisioner-1.1.0-k8s1.10 branch July 10, 2018 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants