Solves #2933: Allow http_proxy, https_proxy and no_proxy environment variables in cert-manager playbook

[fllaca]

Solves #2933

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Atoms]

i cannot see where those cert_manager_controller_* variables are defined, at least in defaults should be added.

[fllaca]

@Atoms I've added them to defaults with "" as default value. I didn't originally declare them there because Jinja template was checking that the variables were defined ({% if cert_manager_controller_http_proxy %}. But yes, I think better make them explicit in defaults. Take a look again, please, thanks! 😄

[Atoms]

/lifecycle frozen

[Atoms]

Please rebase PR and resolve conflicts

[woopstar]

ping @fllaca

[floryut]

Can't keep a PR open indefinitely.. codebase changed a lot, @fllaca if you are still on github please reopen and rebase/resubmit.
/close

[k8s-ci-robot]

@fllaca: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@floryut: Closed this PR.

In response to this:

Can't keep a PR open indefinitely.. codebase changed a lot, @fllaca if you are still on github please reopen and rebase/resubmit.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.