Simplify package selection + fix openEuler package #11688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since a2019c1 (Add a JSON schema describing the packages install structure, 2024-04-25), we use a custom structure to select which packages should be installed on a particular host OS. This has proven too rigid in practice, and the query is pretty complicated. Replace this by simply using an array of jinja conditions for the packages, which should be easier to understand for everyone and more flexible. Also remove the associated schema and validation which are no longer needed.
conntrack -> conntrack-tools device-mapper-libs -> device-mapper
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/label ci-extended |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This abandon the structure put in place in #11131 in favor of jinja templating directly in the data.
Which issue(s) this PR fixes:
Fixes #11660
Special notes for your reviewer:
see first commit for the rationale of switching to a more-free form logic.
Does this PR introduce a user-facing change?:
/label tide/merge-method-merge
@leeonfu can you test if this fix your problem ?