Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debian11-custom-cni failing test & upgrade debian12-custom-cni-helm chart version #11654

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Fix debian11-custom-cni failing test & upgrade debian12-custom-cni-helm chart version #11654

merged 5 commits into from
Oct 22, 2024

Conversation

tico88612
Copy link
Member

@tico88612 tico88612 commented Oct 21, 2024 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

#11530 uses ci-full, but debian11-custom-cni has a failing test. I think the Cilium version is outdated. (Reason: kube_owner: root is required if CNI is cilium.)

Which issue(s) this PR fixes:

Related #11530

Special notes for your reviewer:

I will revert [WIP] commit after get approved.

Does this PR introduce a user-facing change?:

NONE

@tico88612
Test: update custom_cni values
66d71b9 
Signed-off-by: ChengHao Yang <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 21, 2024
@tico88612
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 21, 2024
@tico88612 tico88612 force-pushed the test/fix-debian11-custom-cni branch from 317c1c2 to c40da01 Compare October 22, 2024 01:13
@tico88612 tico88612 mentioned this pull request Oct 22, 2024
Merged
@tico88612
Copy link
Member Author

Passed.

image

@VannTen
Copy link
Contributor

VannTen commented Oct 22, 2024 via email

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@tico88612 tico88612 force-pushed the test/fix-debian11-custom-cni branch from c40da01 to 12bae47 Compare October 22, 2024 14:11
@tico88612 tico88612 changed the title [WIP] Fix debian11-custom-cni failing test & upgrade debian12-custom-cni-helm chart version Fix debian11-custom-cni failing test & upgrade debian12-custom-cni-helm chart version Oct 22, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@tico88612
Copy link
Member Author

Ready to merge and cherry-pick to other branches.

/cherry-pick release-2.26
/cherry-pick release-2.25

@k8s-infra-cherrypick-robot
Copy link

@tico88612: once the present PR merges, I will cherry-pick it on top of release-2.26 in a new PR and assign it to you.

In response to this:

Ready to merge and cherry-pick to other branches.

/cherry-pick release-2.26
/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@VannTen
Copy link
Contributor

VannTen commented Oct 22, 2024 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit e119863 into kubernetes-sigs:master Oct 22, 2024
40 checks passed
@k8s-infra-cherrypick-robot
Copy link

@tico88612: new pull request created: #11658

In response to this:

Ready to merge and cherry-pick to other branches.

/cherry-pick release-2.26
/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 22, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@tico88612: new pull request created: #11659

In response to this:

Ready to merge and cherry-pick to other branches.

/cherry-pick release-2.26
/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 22, 2024
Merged
@tico88612 tico88612 deleted the test/fix-debian11-custom-cni branch October 22, 2024 16:04
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@tico88612 @kpoxo6op
Fix debian11-custom-cni failing test & upgrade `debian12-custom-cni…
557970c 
…-helm` chart version (kubernetes-sigs#11654)

* Test: update custom_cni values

Signed-off-by: ChengHao Yang <[email protected]>

* Test: fix cilium require kube_owner set to root

Signed-off-by: ChengHao Yang <[email protected]>

* Test: update custom_cni render manifests

Signed-off-by: ChengHao Yang <[email protected]>

* Test: fix render template pre-commit

Signed-off-by: ChengHao Yang <[email protected]>

* Test: update debian12-custom-cni-helm chart version to 1.16.3

Signed-off-by: ChengHao Yang <[email protected]>

---------

Signed-off-by: ChengHao Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VannTen VannTen Awaiting requested review from VannTen

@yankay yankay Awaiting requested review from yankay

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tico88612 @VannTen @k8s-ci-robot @k8s-infra-cherrypick-robot