[etcd] make etcd 3.5.16 default

[janosbabik]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Related issue: #11555

Does this PR introduce a user-facing change?:

[etcd] Default version to 3.5.16 for 1.28, 1.29, 1.30, 1.31

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: janosbabik (344341d, a05994e)

[k8s-ci-robot]

Welcome @janosbabik!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @janosbabik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[VannTen]

/approve /lgtm /ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janosbabik, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [VannTen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VannTen]

Hum, yeah, without the checksums this isn't going to work ^^

[VannTen]

/lgtm

[janosbabik]

Hi @VannTen, what is the way to cherry pick this to 2.25 and 2.26?

[VannTen]

A direct cherry-pick probably won't work, so you probably need to do it manually by relauching the script manually on those branches Let's try it anyway: /cherrypick release-2.26 /cherrypick release-2.25

[k8s-infra-cherrypick-robot]

@VannTen: #11572 failed to apply on top of branch "release-2.26":

Applying: make etcd 3.5.16 default
Using index info to reconstruct a base tree...
M	README.md
M	roles/kubespray-defaults/defaults/main/download.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/kubespray-defaults/defaults/main/download.yml
CONFLICT (content): Merge conflict in roles/kubespray-defaults/defaults/main/download.yml
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 make etcd 3.5.16 default
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

A direct cherry-pick probably won't work, so you probably need to do it manually by relauching the script manually on those branches

Let's try it anyway:

/cherrypick release-2.26
/cherrypick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[VannTen]

Yep, conflicts, as expected.