Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.25] Fix CI: elastx cleanup security groups #11537

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[release-2.25] Fix CI: elastx cleanup security groups #11537

merged 1 commit into from
Sep 18, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #11411

/assign tico88612

Fix CI: elastx cleanup security groups

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 15, 2024
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 15, 2024
@tico88612
Copy link
Member

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 15, 2024
@tico88612
Copy link
Member

/retest-failed

@tico88612
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2024
@tico88612
Copy link
Member

@VannTen @yankay, could you help me to give this PR /approve? Thanks.

@VannTen
Copy link
Contributor

VannTen commented Sep 18, 2024 via email

@tico88612
Copy link
Member

I dont' have approval rights on the 2.25 branch afaik

#11510, I think you should have approval permission.

@yankay
Copy link
Member

yankay commented Sep 18, 2024

Thanks @tico88612
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1223ad2 into kubernetes-sigs:release-2.25 Sep 18, 2024
39 checks passed
@VannTen
Copy link
Contributor

VannTen commented Sep 18, 2024 via email

@robertvolkmann
Copy link
Contributor

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Oct 10, 2024
@robertvolkmann robertvolkmann mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

@yankay yankay Awaiting requested review from yankay

Assignees

@tico88612 tico88612

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @tico88612 @VannTen @yankay @k8s-ci-robot @robertvolkmann