[release-2.25] pre-commit: make hooks self contained + ci config #11359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
This pre-commit does not require prerequisite on the host, making it easier to run in CI workflows.
This way, the hook is self contained and does not depend on a previous virtualenv installation.
- ansible-syntax-check - tox-inventory-builder - jinja-syntax-check
- Remove dependency of pydblite which fails to setup on recent pythons - Discard shell script and put everything into pre-commit
- markdownlint (manual fix) - end-of-file-fixer - requirements-txt-fixer - trailing-whitespace
client9/misspell is unmaintained, and has been forked by the golangci team, see client9/misspell#197 (comment). They haven't yet added a pre-commit config, so use my fork with the pre-commit hook config until the pull request is merged.
Use gitlab dynamic child pipelines feature to have one source of truth for the pre-commit jobs, the pre-commit config file. Use one cache per pre-commit. This should reduce the "fetching cache" time steps in gitlab-ci, since each job will have a separate cache with only its hook installed.
Use a style file as recommended by upstream. This makes for only one source of truth. Conserve previous upstream default for MD007 (upstream default changed here markdownlint/markdownlint#373)
k8s-infra-cherrypick-robot
force-pushed
the
cherry-pick-11226-to-release-2.25
branch
from
6d1084c to
ead0948
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Continue to upstream the current CI. |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #11226
/assign tico88612