-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix task Set label to node #11307
fix task Set label to node #11307
Conversation
|
Hi @DANic-git. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c00b01f
to
20a5784
Compare
/ok-to-test |
Thanks @DANic-git |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ant31, DANic-git The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Hardening required that kubernetes Kubelet must deny hostname override
kubespray/roles/kubernetes/node/templates/kubelet.env.v1beta1.j2
Line 3 in 24dc4ce
It's possible only if
kube_override_hostname
is emptyBut when kube_override_hostname is empty, task Set label to node is broken, because
{{ kube_override_hostname | default(inventory_hostname) }}
is empty tooWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: