-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup galaxy.yml #11239
Cleanup galaxy.yml #11239
Conversation
/hold
|
The default for galaxy. `manifest` works well enough for our case, and this avoids maintaining a blacklist.
f9e883d
to
8700495
Compare
/label tide/merge-method-merge |
/hold cancel |
/cc @MrFreezeex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ant31, MrFreezeex, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We include too much stuff in the collection, in particular apparently contrib/ and .vagrant/ (?)
Special notes for your reviewer:
On top of #11226
@ant31, done this one as a separate PR to test the gitlab integration
EDIT: There is only the last commit not in master, I don't know why Github is unable to show the actuall diff 🤔
Does this PR introduce a user-facing change?: