Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup galaxy.yml #11239

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 28, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We include too much stuff in the collection, in particular apparently contrib/ and .vagrant/ (?)

Special notes for your reviewer:
On top of #11226
@ant31, done this one as a separate PR to test the gitlab integration

EDIT: There is only the last commit not in master, I don't know why Github is unable to show the actuall diff 🤔

Does this PR introduce a user-facing change?:

contrib playbooks are no longer included in the ansible kubespray collection

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2024
@k8s-ci-robot k8s-ci-robot requested review from mzaian and oomichi May 28, 2024 11:35
@VannTen
Copy link
Contributor Author

VannTen commented May 28, 2024 via email

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2024
@ant31 ant31 closed this May 28, 2024
@ant31 ant31 reopened this May 28, 2024
The default for galaxy. `manifest` works well enough for our case, and
this avoids maintaining a blacklist.
@VannTen VannTen force-pushed the cleanup/collection-build-test branch from f9e883d to 8700495 Compare May 29, 2024 11:57
@VannTen
Copy link
Contributor Author

VannTen commented May 29, 2024

/label tide/merge-method-merge

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label May 29, 2024
@VannTen
Copy link
Contributor Author

VannTen commented May 30, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2024
@VannTen
Copy link
Contributor Author

VannTen commented May 30, 2024

/cc @MrFreezeex

@k8s-ci-robot k8s-ci-robot requested a review from MrFreezeex May 30, 2024 07:57
@VannTen VannTen changed the base branch from master to update-approvers-ant31 May 30, 2024 08:01
@VannTen VannTen changed the base branch from update-approvers-ant31 to master May 30, 2024 08:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2024
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@VannTen
Copy link
Contributor Author

VannTen commented May 30, 2024 via email

@ant31
Copy link
Contributor

ant31 commented May 30, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0624a30 into kubernetes-sigs:master May 30, 2024
77 checks passed
@yankay yankay mentioned this pull request Aug 28, 2024
@VannTen VannTen deleted the cleanup/collection-build-test branch November 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants