Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.24] [ingress-nginx] Fix nginx controller leader election RBAC permissions #11219

Conversation

mochizuki875
Copy link
Member

@mochizuki875 mochizuki875 commented May 21, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

cherry-pick of #10569

This fix has been merged to release-2.23 and master branch, but doesn't seems to have been merged to release-2.24 yes.

rf: #10569 (comment)

Which issue(s) this PR fixes:
Fixes #10276

Does this PR introduce a user-facing change?:

Fix nginx controller leader election RBAC

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 21, 2024
Copy link

linux-foundation-easycla bot commented May 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mzaian / name: Mohamed Omar Zaian (bd6e4d4)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 21, 2024
@mochizuki875
Copy link
Member Author

/cc @mzaian

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2024
@mochizuki875 mochizuki875 force-pushed the fix-nginx-election-bug_release-2.24 branch from 73d5865 to bd6e4d4 Compare May 21, 2024 06:54
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 21, 2024
@VannTen
Copy link
Contributor

VannTen commented May 21, 2024

/lgtm
(Btw, we now can use the cherrypick <target-branch> command to cherrypick PR, provided by prow)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@VannTen
Copy link
Contributor

VannTen commented May 21, 2024

/assign @mzaian @yankay

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mochizuki875
Copy link
Member Author

/lgtm (Btw, we now can use the cherrypick <target-branch> command to cherrypick PR, provided by prow)

Oh, I didn't know, thanks!

@mochizuki875
Copy link
Member Author

Thank you for adding /lgtm!
Could anyone add /approve?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mochizuki875, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit b9fdda4 into kubernetes-sigs:release-2.24 May 22, 2024
65 checks passed
@mochizuki875 mochizuki875 deleted the fix-nginx-election-bug_release-2.24 branch June 11, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants