-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert OCCM standard dnsPolicy to ClusterFirst and make dnsPolicy con… #11168
Conversation
…figurable to support 10618
Hi @Payback159. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Given the discussion on the issue and on slack:
/lgtm
|
/ok-to-test |
/assign @cristicalin @mzaian
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, Payback159 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…figurable to support 10618 (kubernetes-sigs#11168)
…figurable to support 10618 (kubernetes-sigs#11168)
…figurable to support 10618 (kubernetes-sigs#11168)
…figurable to support 10618
What type of PR is this?
/kind bug
What this PR does / why we need it:
Revert OCCM standard dnsPolicy to ClusterFirst to fix #10914 which was introduced with #10618 and make dnsPolicy configurable to furthermore support #10618
Which issue(s) this PR fixes:
Fixes #10914
Special notes for your reviewer:
The original manifest from OCCM has no dnsPolicy set at all and according to the Kubernetes documentation it falls on
ClusterFirst
. https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/That's the reason why I am using ClusterFirst as the default value for the new introduced variable.
Does this PR introduce a user-facing change?: