-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kube-vip to v0.8.0 #11156
Update kube-vip to v0.8.0 #11156
Conversation
Welcome @jisnardo! |
Hi @jisnardo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
af5c84a
to
b1d9f1b
Compare
Hello @jisnardo Thanks a lot for the PR. Did you check If you need to update the manifests Ref: https://github.com/kube-vip/kube-vip/blob/v0.8.0/pkg/kubevip/config_generator.go /ok-to-test |
Hi @mzaian, now yes Thanks. |
/retest-required |
/retest |
1 similar comment
/retest |
@mzaian what about this? packet_centos7-flannel-addons-ha https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/6783243276 |
The error are visible here
|
/lgtm |
@jisnardo: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Now ready @mzaian, thanks |
Thanks @mzaian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required |
I'm not sure how we can override the status, because the CI is green, it's only the integration to gitlab which was broken due to token expiration and does not appear to be able to unstuck itself... 🤔 |
/override kubespray-ci/pipeline |
@jisnardo Could you please rebase your branch. |
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mzaian done. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jisnardo, mzaian, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Keep kube-vip updated
Which issue(s) this PR fixes:
Fixes # version
Special notes for your reviewer:
Keep kube-vip updated
Does this PR introduce a user-facing change?: