Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: dependabot initial config #11084

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Feat: dependabot initial config #11084

merged 2 commits into from
Apr 25, 2024

Conversation

tico88612
Copy link
Member

@tico88612 tico88612 commented Apr 13, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Add dependabot help maintainers update dependencies to the latest

Which issue(s) this PR fixes:
Fixes #11008

Special notes for your reviewer:
image

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @tico88612!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tico88612. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2024
@tico88612
Copy link
Member Author

We should exclude the .github path from ansible-lint.

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/6617208812#L182

What do you think?

@yankay
Copy link
Member

yankay commented Apr 14, 2024

We should exclude the .github path from ansible-lint.

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/6617208812#L182

What do you think?

Yes, I think so.

@yankay
Copy link
Member

yankay commented Apr 14, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2024
@tico88612
Copy link
Member Author

tico88612 commented Apr 14, 2024

What is the reason for this failure?
Do I need to fix it?

UPD: #11086 WIP

@yankay
Copy link
Member

yankay commented Apr 16, 2024

Thanks @tico88612
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@yankay yankay removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@yankay
Copy link
Member

yankay commented Apr 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit cd7d11f into kubernetes-sigs:master Apr 25, 2024
60 checks passed
@tico88612 tico88612 deleted the feat/dependabot branch April 25, 2024 08:37
@mzaian mzaian mentioned this pull request Apr 26, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
* Feat: dependabot initial config

Signed-off-by: tico88612 <[email protected]>

* Feat: ignore yaml lint check .github path

Signed-off-by: tico88612 <[email protected]>

---------

Signed-off-by: tico88612 <[email protected]>
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
* Feat: dependabot initial config

Signed-off-by: tico88612 <[email protected]>

* Feat: ignore yaml lint check .github path

Signed-off-by: tico88612 <[email protected]>

---------

Signed-off-by: tico88612 <[email protected]>
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
* Feat: dependabot initial config

Signed-off-by: tico88612 <[email protected]>

* Feat: ignore yaml lint check .github path

Signed-off-by: tico88612 <[email protected]>

---------

Signed-off-by: tico88612 <[email protected]>
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
* Feat: dependabot initial config

Signed-off-by: tico88612 <[email protected]>

* Feat: ignore yaml lint check .github path

Signed-off-by: tico88612 <[email protected]>

---------

Signed-off-by: tico88612 <[email protected]>
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
* Feat: dependabot initial config

Signed-off-by: tico88612 <[email protected]>

* Feat: ignore yaml lint check .github path

Signed-off-by: tico88612 <[email protected]>

---------

Signed-off-by: tico88612 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dependabot
4 participants