Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 calico-cni-plugin missing RBAC #11077

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: 🐛 calico-cni-plugin missing RBAC #11077

merged 1 commit into from
Apr 22, 2024

Conversation

MatthieuFin
Copy link
Contributor

@MatthieuFin MatthieuFin commented Apr 12, 2024 •
edited
Loading

To configure node asNumber for per node peering service account calico-cni-plugin need nodes/status update rights

✅ Closes: #11076

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #11076

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 12, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @MatthieuFin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2024
@MatthieuFin
fix: 🐛 calico-cni-plugin missing RBAC
e50900c 
To configure node asNumber for per node peering service account
calico-cni-plugin need nodes/status update rights

✅ Closes: 11076
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 12, 2024
@yankay
Copy link
Member

yankay commented Apr 12, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2024
cyclinder
cyclinder approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@cyclinder cyclinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2024
@yankay
Copy link
Member

yankay commented Apr 14, 2024

Thanks @MatthieuFin
/lgtm

mzaian
mzaian approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MatthieuFin

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, MatthieuFin, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4db3e2c into kubernetes-sigs:master Apr 22, 2024
60 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
Closed
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
@MatthieuFin @dibi-codes
fix: 🐛 calico-cni-plugin missing RBAC (kubernetes-sigs#11077)
2673392 
To configure node asNumber for per node peering service account
calico-cni-plugin need nodes/status update rights

✅ Closes: 11076
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@MatthieuFin @pedromcpedro
fix: 🐛 calico-cni-plugin missing RBAC (kubernetes-sigs#11077)
fe1203c 
To configure node asNumber for per node peering service account
calico-cni-plugin need nodes/status update rights

✅ Closes: 11076
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@MatthieuFin @Rickkwa
fix: 🐛 calico-cni-plugin missing RBAC (kubernetes-sigs#11077)
3a73a8a 
To configure node asNumber for per node peering service account
calico-cni-plugin need nodes/status update rights

✅ Closes: 11076
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
@MatthieuFin @davidumea
fix: 🐛 calico-cni-plugin missing RBAC (kubernetes-sigs#11077)
528ada7 
To configure node asNumber for per node peering service account
calico-cni-plugin need nodes/status update rights

✅ Closes: 11076
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@MatthieuFin @kpoxo6op
fix: 🐛 calico-cni-plugin missing RBAC (kubernetes-sigs#11077)
30e2bfc 
To configure node asNumber for per node peering service account
calico-cni-plugin need nodes/status update rights

✅ Closes: 11076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclinder cyclinder cyclinder approved these changes

@mzaian mzaian mzaian approved these changes

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

Assignees

@mzaian mzaian

@yankay yankay

@cyclinder cyclinder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing RBAC in calico cluster role
5 participants
@MatthieuFin @k8s-ci-robot @yankay @mzaian @cyclinder