crio container runtime crio_registries path fix

[pedro-peter]

What type of PR is this?
/kind bug

What this PR does / why we need it:
when using the crio container runtime and enabling crio_registries:
https://github.com/kubernetes-sigs/kubespray/blob/master/docs/cri-o.md#allcrioyml

if the registry prefix or location variables contain paths (e.g. location: "my-registry/location/prod") the container-engine/cri-o : Cri-o | write registries configs task fails.

Which issue(s) this PR fixes:
Fixes #11029

Special notes for your reviewer:
the task:
https://github.com/kubernetes-sigs/kubespray/blob/master/roles/container-engine/cri-o/tasks/main.yaml#L158

replaces : -> _. This PR will do the same for /. I.E. replace / -> _

inventory:

vars:
  container_manager: crio
  # remap my-registry prod path -> testing
  crio_registries:
    - prefix: "my-registry/location/prod"
      insecure: false
      blocked: false
      location: "my-registry/location/testing"
      unqualified: false

will result in file:

ls /etc/containers/registries.conf.d
01-unqualified.conf  10-my-registry_location_prod_config.conf

Does this PR introduce a user-facing change?:

 fix crio registries config file when using slashes in the registry path

[k8s-ci-robot]

Hi @pedro-peter. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pedro-peter]

/kind bug

[yankay]

/ok-to-test

[yankay]

Thanks @pedro-peter
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedro-peter, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VannTen]

I think it should be better to have a dict instead of an array, and use the key for the filename instead of hijacking location or prefix like that. But it's not worth a breaking change (which it would be) so let's settle for regex_replace.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: pedro-peter / name: peterw (0a01f54)

[VannTen]

Looks ok to me but a few things: - the release note should be more explicit about what is fixed - you should probably rebase on master, I think the amazon Linux ci failure is fixed here

[pedro-peter]

updated release note & rebased of master.

[VannTen]

Please rebase, I don't think the cilium stuff is related ?

[VannTen]

/lgtm

[pedro-peter]

thanks @VannTen