-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: config hostname as string type in kubeadmConfig rendering #10997
fix: config hostname as string type in kubeadmConfig rendering #10997
Conversation
Signed-off-by: bo.jiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :D
/lgtm
/lgtm |
I don't have approval rights you know ^^
|
Thanks for all @ErikJiang @VannTen |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyclinder, ErikJiang, MrFreezeex, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…tes-sigs#10997) Signed-off-by: bo.jiang <[email protected]>
…tes-sigs#10997) Signed-off-by: bo.jiang <[email protected]>
…tes-sigs#10997) Signed-off-by: bo.jiang <[email protected]>
…tes-sigs#10997) Signed-off-by: bo.jiang <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
When rendering the kubeadm configuration file, the hostname may sometimes be a numeric name.
If double quotes are not added, kubeadm init may detect it as a numeric type and throw an error.
Examples of such error messages are as follows:
Which issue(s) this PR fixes:
Fixes #10864
Special notes for your reviewer:
Does this PR introduce a user-facing change?: