Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show log on vagrant #10958

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Feb 26, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Should make it easier to understand what's going on when testing locally
and in CI.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@VannTen VannTen force-pushed the feat/vagrant_unsafe_show_log branch 3 times, most recently from 94db277 to 28f8c37 Compare February 26, 2024 11:21
Should make it easier to understand what's going on when testing locally
and in CI.
@VannTen
Copy link
Contributor Author

VannTen commented Feb 26, 2024

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 26, 2024
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Feb 26, 2024 via email

@VannTen
Copy link
Contributor Author

VannTen commented Mar 14, 2024

/assign @mzaian

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7ddc175 into kubernetes-sigs:master Mar 14, 2024
60 checks passed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request Mar 23, 2024
Should make it easier to understand what's going on when testing locally
and in CI.
@mzaian mzaian mentioned this pull request Apr 26, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
Should make it easier to understand what's going on when testing locally
and in CI.
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Should make it easier to understand what's going on when testing locally
and in CI.
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
Should make it easier to understand what's going on when testing locally
and in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants