Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mirwan from approvers #10930

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Feb 16, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Since they are no longer in the kubernetes-sigs organization, they can no longer be assigned PR to approve.
#10857 (comment)
kubernetes/org@75563bf

Apparently the OWNERS validations does not allow non-org members to be in emeritus approvers as well...

Does this PR introduce a user-facing change?:

Remove mirwan from approvers

@mirwan Thanks for you contributions o/

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 16, 2024
@VannTen VannTen force-pushed the cleanup/owners_mirwan branch from 849d56d to 3306dad Compare February 16, 2024 09:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 16, 2024
Since they are no longer in the kubernetes-sigs organization, they can
no longer be assigned PR to approve.
@VannTen VannTen force-pushed the cleanup/owners_mirwan branch from 3306dad to 8ed2003 Compare February 16, 2024 09:31
@VannTen VannTen changed the title Move mirwan into emeritus approvers Remove mirwan from approvers Feb 16, 2024
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen Thanks for the followup 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4a259ee into kubernetes-sigs:master Feb 19, 2024
65 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
Since they are no longer in the kubernetes-sigs organization, they can
no longer be assigned PR to approve.
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Since they are no longer in the kubernetes-sigs organization, they can
no longer be assigned PR to approve.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants