-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typos in inventory/sample/group_vars/k8s_cluster #10911
Conversation
|
Welcome @arahmangulov! |
Hi @arahmangulov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arahmangulov
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arahmangulov, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR fixes typos in group vars of the sample inventory:
metallb_config
in the user inventory (created by inventory builder): extral
letter in thetollerations
word which affets the metallb_config.controller.tolerations if-statement, since by default theTolerations
of the speaker contains only a default:node-role.kubernetes.io/control-plane:NoSchedule op=Exists
, there is no custom defined toleration.Note: The current install guide and other corresponding metallb yamls are correct within tolerations usage.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: