Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated ingress controller version #10868

Merged
merged 1 commit into from
Feb 12, 2024
Merged

updated ingress controller version #10868

merged 1 commit into from
Feb 12, 2024

Conversation

kundan2707
Copy link
Contributor

@kundan2707 kundan2707 commented Feb 2, 2024 •
edited by floryut
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #10855

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Updated ingress controller version to 1.9.6

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2024
@kundan2707
Copy link
Contributor Author

updated controller version as per ingress-nginx repo

@VannTen
Copy link
Contributor

VannTen commented Feb 5, 2024

This is only the documentation, I thought the actual version in of the ingress deployed in kubernetes-apps

@kundan2707
Copy link
Contributor Author

@VannTen i will also update version for actual version in of the ingress deployed in kubernetes-apps with latest

@kundan2707
Copy link
Contributor Author

/retest

@kundan2707
Copy link
Contributor Author

/test check-readme-versions

@k8s-ci-robot
Copy link
Contributor

@kundan2707: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-kubespray-yamllint

Use /test all to run all jobs.

In response to this:

/test check-readme-versions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kundan2707
Copy link
Contributor Author

/test all

floryut
floryut approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kundan2707 Thank you

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, kundan2707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@VannTen
Copy link
Contributor

VannTen commented Feb 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit bfbb3f8 into kubernetes-sigs:master Feb 12, 2024
65 checks passed
@VannTen
Copy link
Contributor

VannTen commented Feb 12, 2024

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 12, 2024
@mzaian mzaian mentioned this pull request Apr 26, 2024
Closed
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
@kundan2707 @dibi-codes
updated ingress controller version (kubernetes-sigs#10868)
78292f7
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@kundan2707 @pedromcpedro
updated ingress controller version (kubernetes-sigs#10868)
6ed4d59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@holmsten holmsten Awaiting requested review from holmsten

@yankay yankay Awaiting requested review from yankay

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller version is outdated
4 participants
@kundan2707 @VannTen @k8s-ci-robot @floryut