-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download hash script: auto discover versions #10849
Download hash script: auto discover versions #10849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, but I am not sure if the automated PR/bot system should use the .py script that only take care of kubernetes version or the .sh version that does all the other tools as well. I guess it could be both depending on what we want to do 🤷♂️
/lgtm
I'm inclined to think python is more maintainable on the long-term. I admit I find it hard to review #10713 because of that |
Well maintainability also depends on everyone familiarity with the language and is quite subjective but apart from that the sh variant handles a lot more things than the py variant. The sh script handles all the checksum for everything (~15 different software probably something like that) and many of those has some specifics that we have to handle there. So I am not opposed of getting rid of the .sh script but there is a lot of work that has to be done on the .py variant to get up to speed... |
On Mon, Jan 29, 2024 at 06:24:29AM -0800, Arthur Outhenin-Chalandre wrote:
Well maintainability also depends on everyone familiarity with the language and is quite subjective but apart from that the sh variant handles a **lot** more things than the py variant.
Ack. I'll look into it see how hard handling the other binaries is
|
Thanks @VannTen for the great feature :-) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, VannTen, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Download patches version automatically from a minor * Automate versions discovery for hash download * Small refactoring
What type of PR is this?
/kind feature
What this PR does / why we need it:
Special notes for your reviewer:
If we can then hook other stuff into that script, we should be able to automate the "Update versions" PR and outsource them to a bot (Prow I guess)
/cc @mzaian @floryut @MrFreezeex
Does this PR introduce a user-facing change?: