Updated vagrant.md #10836
Merged
Updated vagrant.md #10836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
size/XS
floryut
approved these changes
Jan 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, kundan2707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
VannTen
reviewed
Jan 25, 2024
| @@ -1,6 +1,6 @@ | |||
| # Vagrant | |||
|
|
|||
| Assuming you have Vagrant 2.0+ installed with virtualbox, libvirt/qemu or | |||
| Assuming you have Vagrant 2.0+ installed with virtualbox (it may work with libvirt/qemu or | |||
There was a problem hiding this comment.
Is that actually correct though ? I think the CI works with vagrant-libvirt, do we test virtualbox anywhere ?
$ grep -R vagrant-libvirt
test-infra/vagrant-docker/Dockerfile: vagrant plugin install vagrant-libvirt
pipeline.Dockerfile: && vagrant plugin install vagrant-libvirt \There was a problem hiding this comment.
You are right, I guess the but is untested only concerned the vmware part..
libvirt/qemu is used in ci and vbox is used on local when testing vagrant (for most contributors at least)
|
Thanks @kundan2707 |
k8s-ci-robot
added
the
lgtm
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Typo in vagrant.md
Which issue(s) this PR fixes:
Fixes #10774
Special notes for your reviewer:
Does this PR introduce a user-facing change?: