-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo mistake in roles/kubernetes/control-plane/tasks/define-first-kube-control.yml #10835
Fix typo mistake in roles/kubernetes/control-plane/tasks/define-first-kube-control.yml #10835
Conversation
…-kube-control.yml - Fix 'Set fact joined_control_panes' into 'Set fact joined_control_planes'
Hi @kimsehwan96. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimsehwan96 Thanks for the fix
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, kimsehwan96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Don't need to wait for a whole CI circle for that I guess, force merging this 👍 |
Fix 'Set fact joined_control_panes' into 'Set fact joined_control_planes'
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR is for fixing typo mistake in roles/kubernetes/control-plane/tasks/define-first-kube-control.yml.
I wonder that this change is really needed but I think its better that fix this kind of mistake
Which issue(s) this PR fixes:
It doesn't related with any issue.
Special notes for your reviewer:
Nothing.
Does this PR introduce a user-facing change?: