Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ntp installation on SLES and openSUSE #10786

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix ntp installation on SLES and openSUSE #10786

merged 1 commit into from
Jan 12, 2024

Conversation

goldyfruit
Copy link
Contributor

@goldyfruit goldyfruit commented Jan 11, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
The NTP service name on SLES or openSUSE is ntpd and not ntp. Adding Suse to the list fix the issue.

Before fix, when running the cluster.yml playbook, it fails with message:

TASK [kubernetes/preinstall : Ensure NTP service is started and enabled] *********************************************
fatal: [k8s-master-2.home.lan]: FAILED! => {"changed": false, "msg": "Could not find the requested service ntp: host"}
fatal: [k8s-master-1.home.lan]: FAILED! => {"changed": false, "msg": "Could not find the requested service ntp: host"}
fatal: [k8s-worker-3.home.lan]: FAILED! => {"changed": false, "msg": "Could not find the requested service ntp: host"}
fatal: [k8s-worker-2.home.lan]: FAILED! => {"changed": false, "msg": "Could not find the requested service ntp: host"}
fatal: [k8s-worker-1.home.lan]: FAILED! => {"changed": false, "msg": "Could not find the requested service ntp: host"}
fatal: [k8s-master-3.home.lan]: FAILED! => {"changed": false, "msg": "Could not find the requested service ntp: host"}
fatal: [k8s-worker-4.home.lan]: FAILED! => {"changed": false, "msg": "Could not find the requested service ntp: host"}
fatal: [k8s-worker-5.home.lan]: FAILED! => {"changed": false, "msg": "Could not find the requested service ntp: host"}

Does this PR introduce a user-facing change?:

Fix ntp installation on SLES and openSUSE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 11, 2024
Copy link

linux-foundation-easycla bot commented Jan 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: goldyfruit / name: Gaëtan Trellu (e54b8c4)

@k8s-ci-robot
Copy link
Contributor

Welcome @goldyfruit!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @goldyfruit. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 11, 2024
@yankay
Copy link
Member

yankay commented Jan 11, 2024

Thanks @goldyfruit
/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@yankay yankay added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2024
@goldyfruit
Copy link
Contributor Author

Thanks @yankay 👍

What would be the procedure to add openSUSE Leap 15.x to the Kubespray CI? This would have been caught earlier for sure.

@yankay
Copy link
Member

yankay commented Jan 11, 2024

openSUSE

HI @goldyfruit

The OpenSuse-leap-15 is in the kubespray CI, but it does not coverage the NTP setting :-)
It's welcome to add more tests :-)

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goldyfruit Thank you for the PR 🙇
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, goldyfruit, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@yankay
Copy link
Member

yankay commented Jan 12, 2024

Thanks @goldyfruit
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 747d8bb into kubernetes-sigs:master Jan 12, 2024
65 checks passed
@yankay yankay mentioned this pull request Jan 12, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants