Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubernetes] Add hashes for kubernetes 1.29.0 and 1.29.1 #10778

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[kubernetes] Add hashes for kubernetes 1.29.0 and 1.29.1 #10778

merged 1 commit into from
Jan 22, 2024

Conversation

tmurakam
Copy link
Contributor

@tmurakam tmurakam commented Jan 8, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Add hashes of crictl and crio for kubernetes 1.29.0 and 1.29.1
  • Add versions of etcd, crictl, crio and csi-snapshotter for kubernetes 1.29

Special notes for your reviewer:
This does NOT change default kubernetes version. (Does not fix #10735)
I updated the csi-snapshotter to currently supported version

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tmurakam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2024
@yankay
Copy link
Member

yankay commented Jan 8, 2024

pending #10720

@yankay
Copy link
Member

yankay commented Jan 9, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2024
@tmurakam tmurakam force-pushed the feature/hashes-k8s-1.29 branch 2 times, most recently from c6799ad to f463f13 Compare January 11, 2024 02:51
@VannTen
Copy link
Contributor

VannTen commented Jan 11, 2024

/lgtm
/hold
(until the release is out)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 11, 2024
@tmurakam tmurakam force-pushed the feature/hashes-k8s-1.29 branch from f463f13 to 47204e5 Compare January 18, 2024 01:58
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2024
@tmurakam tmurakam force-pushed the feature/hashes-k8s-1.29 branch from 47204e5 to c4e3fcf Compare January 18, 2024 04:30
@tmurakam tmurakam changed the title [kubernetes] Add hashes for kubernetes 1.29.0 [kubernetes] Add hashes for kubernetes 1.29.0 and 1.29.1 Jan 18, 2024
@tmurakam
[kubernetes] Add hashes for kubernetes 1.29.0 and 1.29.1
9abdf30 
* Add hashes of crictl and crio
* Add versions of etcd, crictl, crio and csi-snapshotter
@tmurakam tmurakam force-pushed the feature/hashes-k8s-1.29 branch from c4e3fcf to 9abdf30 Compare January 19, 2024 12:45
@yankay
Copy link
Member

yankay commented Jan 22, 2024

Thanks @tmurakam
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmurakam, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@VannTen
Copy link
Contributor

VannTen commented Jan 22, 2024

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4cb1f52 into kubernetes-sigs:master Jan 22, 2024
65 checks passed
@tmurakam tmurakam deleted the feature/hashes-k8s-1.29 branch January 22, 2024 08:42
@mzaian mzaian mentioned this pull request Apr 26, 2024
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@tmurakam @pedromcpedro
[kubernetes] Add hashes for kubernetes 1.29.0 and 1.29.1 (kubernetes-…
aa5e92d 
…sigs#10778)

* Add hashes of crictl and crio
* Add versions of etcd, crictl, crio and csi-snapshotter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

@yankay yankay Awaiting requested review from yankay

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.29 Support
4 participants
@tmurakam @k8s-ci-robot @yankay @VannTen