Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scheduler plugins support #10747

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add scheduler plugins support #10747

merged 1 commit into from
Jan 23, 2024

Conversation

0ekk
Copy link
Member

@0ekk 0ekk commented Dec 26, 2023 •
edited by floryut
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR intend to replace #10716.
Currently, I start with simple support at first and then move on to support more capabilities.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add scheduler plugins support (`scheduler_plugins_enabled` enable or disable the installation scheduler plugins / `scheduler_plugins_enabled_plugins` describe the enabled plugins / `scheduler_plugins_diabled_plugins` describe the disabled plugins / `scheduler_plugins_plugin_config` set the custom config for enabled plugins)

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 26, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 26, 2023
@0ekk 0ekk force-pushed the add_scheduler_plugins_support2 branch 4 times, most recently from 84f4f0c to cceddba Compare December 26, 2023 08:49
yankay
yankay reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@yankay yankay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding an CI TestCase of the feature:-)

docs/kubernetes-apps/scheduler_plugins.md Outdated Show resolved Hide resolved
@0ekk 0ekk force-pushed the add_scheduler_plugins_support2 branch from cceddba to f014810 Compare January 15, 2024 09:19
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2024
@0ekk
Copy link
Member Author

0ekk commented Jan 15, 2024

How about adding an CI TestCase of the feature:-)

Done.
PTAL :-)

@0ekk 0ekk force-pushed the add_scheduler_plugins_support2 branch 2 times, most recently from 24ba69b to 5b1d2e4 Compare January 15, 2024 09:28
@0ekk 0ekk force-pushed the add_scheduler_plugins_support2 branch from 5b1d2e4 to 38232d2 Compare January 15, 2024 09:34
@yankay
Copy link
Member

yankay commented Jan 18, 2024

Thanks a lot @tu1h
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@0ekk
Copy link
Member Author

0ekk commented Jan 18, 2024

Hi @mzaian @floryut @VannTen
Could you please take a look at it?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, tu1h, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ErikJiang
Copy link
Member

good job @tu1h

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit a88bad7 into kubernetes-sigs:master Jan 23, 2024
65 checks passed
@yankay yankay mentioned this pull request Jan 24, 2024
Closed
@0ekk 0ekk mentioned this pull request Feb 26, 2024
Closed
@mzaian mzaian mentioned this pull request Apr 26, 2024
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@0ekk @pedromcpedro
Add scheduler plugins support (kubernetes-sigs#10747)
c14aef8 
Signed-off-by: tu1h <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankay yankay yankay left review comments

@ErikJiang ErikJiang ErikJiang approved these changes

@EppO EppO Awaiting requested review from EppO

Assignees

@ErikJiang ErikJiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0ekk @yankay @k8s-ci-robot @ErikJiang