Fix the path of download.yml #10711
Merged
Fix the path of download.yml #10711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
Thanks @tu1h |
k8s-ci-robot
added
the
lgtm
MrFreezeex
approved these changes
Dec 12, 2023
VannTen
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Sorry, somehow those paths fell through the cracks... (maybe the numerous rebases ? No idea)
Could you fix the other instances while you're at it ? (
- contrib/offline/README.md
- comment in generate_list.sh (l. 22)
- docs/offline-environment.md (l 98)
- scripts/download_hash.py (l4, l13)
|
@VannTen Ok, I'll push it again later. :-) |
Signed-off-by: tu1h <[email protected]>
0ekk
force-pushed
the
fix_generate_list
branch
from
7265f86 to
1ed8fa0
Compare
k8s-ci-robot
added
size/S
0ekk
changed the title
|
Great, thanks o/ |
k8s-ci-robot
added
the
lgtm
|
Thanks @tu1h and @VannTen |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, tu1h, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Signed-off-by: tu1h <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Make the path of download.yml correctly. From #10626
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: