Removed DEPRECATED --logtostderr from metrics-server

[michaelkebe]

The --logtostderr is deprecated.

https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The --logtostderr of metrics-server is DEPRECATED.

$ nerdctl --namespace k8s.io  run registry.k8s.io/metrics-server/metrics-server:v0.6.4`

outputs:

--logtostderr                      log to standard error instead of files (DEPRECATED: will be removed in a future release, see https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components) (default true)

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Removed DEPRECATED `--logtostderr` from metrics-server

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: michaelkebe / name: Michael Kebe (88155dc)

[k8s-ci-robot]

Welcome @michaelkebe!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @michaelkebe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@michaelkebe Thank you
/ok-to-test
If need be I'll force merge this, no need to rerun pipeline I guess (cancelled due to many activities at once)

[mzaian]

Thanks @michaelkebe

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, michaelkebe, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut,mzaian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yankay]

HI @michaelkebe

We need to re-push the PR with --amed to retrige the CI.

[michaelkebe]

First I synced the branch patch-1 branch in the GitHub Web UI. Then I realized there more commits are from the master. So I tried to rebase and force push. I hope, this is okay now.

[VannTen]

https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/5744256770 looks like a flake due to some packaging stuff on rocky.
@michaelkebe could you repush to retrigger the ci ? (git commit --amend --no-edit && git push -f)

[michaelkebe]

@VannTen Done. I think lgtm is missing.

[VannTen]

/lgtm