feat: add support for Cilium 1.14

[rl0nergan]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Adds support for Cilium 1.14+ for clusters running k8s v1.27+
Which issue(s) this PR fixes:

Fixes #10465

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adds support for deploying clusters with cilium 1.14+

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rl0nergan / name: Ryan Lonergan (a7ad740, 333b588, 67b405b, 47b4859)

[k8s-ci-robot]

Welcome @rl0nergan!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rl0nergan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yankay]

/ok-to-test

[rl0nergan]

thanks @yankay. Looks like all required tests passed. Is there anything else needed from me? If not, can this be approved and merged please?

[yankay]

Thanks @rl0nergan

Hi @cyclinder , would you please help to review it :-)

[cyclinder]

Hi @cyclinder , would you please help to review it :-)

Sure, I'll take a look at it today.

[pbromb]

Thanks @rl0nergan, in my cluster on bare metal, everything works after upgrading to 1.14

[yankay]

Thanks @rl0nergan,
/lgtm

[rl0nergan]

hey @yankay, can I get an approval here when you have a chance?

[pbromb]

@rl0nergan, the upgrade from 1.13 to 1.14 went through successfully, but the installation of the new node from 1.14 failed, the configuration in /etc/cni/net.d/ was not created. As the cni-install.sh script was removed in version 1.14
it requires additional configuration to initialize the file https://github.com/cilium/cilium/blob/v1.14.0/install/kubernetes/cilium/templates/cilium-configmap.yaml#L778

  # Tell the agent to generate and write a CNI configuration file
  write-cni-conf-when-ready: {{ .Values.cni.hostConfDirMountPath }}/05-cilium.conflist
  cni-exclusive: {{ .Values.cni.exclusive | quote }}
  cni-log-file: {{ .Values.cni.logFile | quote }}

[yankay]

@rl0nergan, the upgrade from 1.13 to 1.14 went through successfully, but the installation of the new node from 1.14 failed, the configuration in /etc/cni/net.d/ was not created. As the cni-install.sh script was removed in version 1.14 it requires additional configuration to initialize the file https://github.com/cilium/cilium/blob/v1.14.0/install/kubernetes/cilium/templates/cilium-configmap.yaml#L778

  # Tell the agent to generate and write a CNI configuration file
  write-cni-conf-when-ready: {{ .Values.cni.hostConfDirMountPath }}/05-cilium.conflist
  cni-exclusive: {{ .Values.cni.exclusive | quote }}
  cni-log-file: {{ .Values.cni.logFile | quote }}

Thanks @pbromb @rl0nergan

/approve
to this PR.

And the cilium_version at https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/download.yml#L120 can be changed later.
So that the CI of v1.14 can be triggered . And if the issue is confirmed as bug , we can fix it in another PR :-)

Best Regards

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, rl0nergan, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[manicole]

@rl0nergan, the upgrade from 1.13 to 1.14 went through successfully, but the installation of the new node from 1.14 failed, the configuration in /etc/cni/net.d/ was not created. As the cni-install.sh script was removed in version 1.14 it requires additional configuration to initialize the file https://github.com/cilium/cilium/blob/v1.14.0/install/kubernetes/cilium/templates/cilium-configmap.yaml#L778

  # Tell the agent to generate and write a CNI configuration file
  write-cni-conf-when-ready: {{ .Values.cni.hostConfDirMountPath }}/05-cilium.conflist
  cni-exclusive: {{ .Values.cni.exclusive | quote }}
  cni-log-file: {{ .Values.cni.logFile | quote }}

Thanks @pbromb @rl0nergan

/approve to this PR.

And the cilium_version at https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/download.yml#L120 can be changed later. So that the CI of v1.14 can be triggered . And if the issue is confirmed as bug , we can fix it in another PR :-)

Best Regards

Hello, referenced as a bug by #10887 @yankay ! Could someone please create the PR ? Many thanks