Jinja syntax pre-commit validation

[VannTen]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allow to fail early (pre-commit time) for jinja error, rather than
waiting until executing the playbook and the invalid template.
This catch simple syntax errors like missing endif/endfor.
-> save CI and dev time

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
I could not find a simple jinja pre-commit hook in the wild.
dansabel tries to check filter names so it does not really work.

Does this PR introduce a user-facing change?:

Jinja syntax pre-commit validation

[k8s-ci-robot]

Hi @VannTen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[VannTen]

Hum I was under the impression than pre-commit hooks and CI jobs were automatically synced. But they are not.
🤔

[MrFreezeex]

HMmm isn't ansible-lint supposed to already check that: https://ansible.readthedocs.io/projects/lint/rules/jinja/? The precommit is probably nice though but not sure about the CI job as it exec ansible-lint in the same CI stage IIRC? If you have a case where ansible-lint was not able to catch something and your new check does, happy to go forward with this as is! 👍

[VannTen]

Somehow ansible-lint does not catch that sort of thing (don't know why), see the test PR CI run.

[MrFreezeex]

Indeed 👌 let's go for this then :D
/lgtm
/ok-to-test

[VannTen]

/assign @liupeng0518
/retest

[floryut]

@VannTen All good thank you

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VannTen]

/retest

[VannTen]

New changes are detected. LGTM label has been removed.

But they're identical ! ^
Anyway, would you mind a new lgtm @MrFreezeex ?

[yankay]

Thanks @VannTen
/lgtm