-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[etcd]: add etcd distributed tracing flags #10666
Conversation
Signed-off-by: Ugur Ozturk <[email protected]>
Hi @ugur99. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ugur Ozturk <[email protected]>
Signed-off-by: Ugur Ozturk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ugur99 Thank you for the PR 👍
/ok-to-test
hi @floryut! I saw some failed pipelines but not sure if they are related to my changes; please ping me if I need to do stg to fix it. |
Hi again @floryut! All jobs are successful now I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ugur99
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mzaian, ugur99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @ugur99 |
* [etcd]: add etcd distributed tracing flags Signed-off-by: Ugur Ozturk <[email protected]> * [etcd]: add etcd distributed tracing flags - fix Signed-off-by: Ugur Ozturk <[email protected]> * [etcd]: add etcd distributed tracing flags - fix Signed-off-by: Ugur Ozturk <[email protected]> --------- Signed-off-by: Ugur Ozturk <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This MR contains small enhancements that allows us to enable ETCD distributed tracing.
Related parameters and variables are defined.
Which issue(s) this PR fixes:
Fixes # none
Special notes for your reviewer:
Since it is strongly recommended that the
experimental-distributed-tracing-instance-id
be unique for each instance, I assigned it toetcd_member_name
value which is unique for per etcd instance instead of giving it as a parameter.Ref: Etcd distributed tracing documentation
Does this PR introduce a user-facing change?: