Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etcd]: add etcd distributed tracing flags #10666

Merged
merged 5 commits into from
Dec 19, 2023
Merged

[etcd]: add etcd distributed tracing flags #10666

merged 5 commits into from
Dec 19, 2023

Conversation

ugur99
Copy link
Contributor

@ugur99 ugur99 commented Nov 29, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This MR contains small enhancements that allows us to enable ETCD distributed tracing.
Related parameters and variables are defined.

Which issue(s) this PR fixes:

Fixes # none

Special notes for your reviewer:
Since it is strongly recommended that the experimental-distributed-tracing-instance-id be unique for each instance, I assigned it to etcd_member_name value which is unique for per etcd instance instead of giving it as a parameter.

Ref: Etcd distributed tracing documentation

Does this PR introduce a user-facing change?:

[etcd] add etcd distributed tracing flags (`etcd_experimental_enable_distributed_tracing`,`etcd_experimental_distributed_tracing_sample_rate`,`etcd_experimental_distributed_tracing_address`,`etcd_experimental_distributed_tracing_service_name`), feature is disabled by default

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ugur99. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ugur99 Thank you for the PR 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2023
@ugur99
Copy link
Contributor Author

ugur99 commented Dec 6, 2023

hi @floryut! I saw some failed pipelines but not sure if they are related to my changes; please ping me if I need to do stg to fix it.

@ugur99
Copy link
Contributor Author

ugur99 commented Dec 18, 2023

Hi again @floryut! All jobs are successful now I guess

@ugur99 ugur99 mentioned this pull request Dec 18, 2023
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ugur99

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mzaian, ugur99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay
Copy link
Member

yankay commented Dec 19, 2023

Thanks @ugur99
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit ae780e6 into kubernetes-sigs:master Dec 19, 2023
64 checks passed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
* [etcd]: add etcd distributed tracing flags

Signed-off-by: Ugur Ozturk <[email protected]>

* [etcd]: add etcd distributed tracing flags - fix

Signed-off-by: Ugur Ozturk <[email protected]>

* [etcd]: add etcd distributed tracing flags - fix

Signed-off-by: Ugur Ozturk <[email protected]>

---------

Signed-off-by: Ugur Ozturk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants