Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined retries variable when copying etcdctl #10634

Merged

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Nov 22, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

TASK [etcdctl_etcdutl : Copy etcdctl and etcdutl binary from docker container] ****************************************************************************************************************************
fatal: [master]: FAILED! => {"msg": "The field 'retries' has an invalid value, which includes an undefined variable. The error was: 'etcd_retries' is undefined. 'etcd_retries' is undefined

The error appears to be in '/kubespray/roles/etcdctl_etcdutl/tasks/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

---
- name: Copy etcdctl and etcdutl binary from docker container
  ^ here
"}

The etcd_retries parameter is not defined in etcdctl_etcdutl role. As far as I know, this variable is only defined in etcd role.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix undefined retries variable when copying etcdctl

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2023
@yankay
Copy link
Member

yankay commented Nov 23, 2023

Thanks @ErikJiang

The CI has been repaired, would you please repush it to trige the CI agiain :-)
/lgtm

@ErikJiang ErikJiang force-pushed the fix_cp_etcdctl_retries branch from b02b3ba to 20b7575 Compare November 27, 2023 03:09
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ErikJiang for the fix

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@yankay
Copy link
Member

yankay commented Nov 28, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 70bb19d into kubernetes-sigs:master Nov 28, 2023
63 checks passed
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants