Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodelocaldns version #10621

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Nov 15, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:
Update nodelocaldns to 1.22.28 https://github.com/kubernetes/dns/releases/tag/1.22.28

Does this PR introduce a user-facing change?:

Bump nodelocaldns to version 1.22.28

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Nov 15, 2023

New version is coming up!
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@mzaian mzaian force-pushed the update-nodelocaldns branch from bed1f49 to d50cf38 Compare November 16, 2023 15:19
@mzaian
Copy link
Contributor Author

mzaian commented Nov 16, 2023

I promoted the new version here kubernetes/k8s.io#6088
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2023
@yankay
Copy link
Member

yankay commented Nov 20, 2023

Thanks @mzaian
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Nov 20, 2023

/hold
As kubernetes/k8s.io#6088 still not merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2023
@mzaian mzaian force-pushed the update-nodelocaldns branch from d50cf38 to 605dc70 Compare November 28, 2023 16:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@floryut
Copy link
Member

floryut commented Nov 28, 2023

/hold As kubernetes/k8s.io#6088 still not merged

It is now 👍
/lgtm

@mzaian I let you unhold this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Nov 29, 2023

/hold As kubernetes/k8s.io#6088 still not merged

It is now 👍 /lgtm

@mzaian I let you unhold this

@floryut Thanks you!

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 75fecf1 into kubernetes-sigs:master Nov 29, 2023
63 checks passed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants