Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: use dynamic group for certs generation check #10610

Merged
merged 1 commit into from
Dec 12, 2023
Merged

etcd: use dynamic group for certs generation check #10610

merged 1 commit into from
Dec 12, 2023

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Nov 10, 2023 •
edited by floryut
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We take advantage of group_by to create the list of nodes needing new
certs, instead of manually looping inside a Jinja template.

This should make the role more readable and less susceptible to
whitespace problems.

Which issue(s) this PR fixes:

might fixes #10609

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

etcd: use dynamic group for certs generation check

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @VannTen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 10, 2023
@VannTen VannTen force-pushed the cleanup/less_jinja_etcd_gen_certs branch 6 times, most recently from 76f71e4 to 0858dde Compare November 10, 2023 14:35
@VannTen VannTen mentioned this pull request Nov 10, 2023
Closed
@VannTen
Copy link
Contributor Author

VannTen commented Nov 13, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@VannTen
etcd: use dynamic group for certs generation check
a2d88fe 
We take advantage of group_by to create the list of nodes needing new
certs, instead of manually looping inside a Jinja template.

This should make the role more readable and less susceptible to
white space problems.
@VannTen VannTen force-pushed the cleanup/less_jinja_etcd_gen_certs branch from 0858dde to a2d88fe Compare November 13, 2023 11:38
@VannTen
Copy link
Contributor Author

VannTen commented Nov 13, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@yankay
Copy link
Member

yankay commented Nov 15, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2023
MrFreezeex
MrFreezeex approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks much cleaner this way 🤝
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2023
@VannTen
Copy link
Contributor Author

VannTen commented Nov 27, 2023

/assign @floryut

@VannTen
Copy link
Contributor Author

VannTen commented Dec 4, 2023

/assign @yankay
Some bandwidth for approval 🙏 ?

floryut
floryut approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen All good, sorry for the lag 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0fb404c into kubernetes-sigs:master Dec 12, 2023
61 checks passed
@yankay
Copy link
Member

yankay commented Dec 13, 2023

Thanks @VannTen

A great refactor :-)

@yankay yankay mentioned this pull request Dec 15, 2023
Closed
@VannTen VannTen mentioned this pull request Jan 11, 2024
Merged
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@VannTen @pedromcpedro
etcd: use dynamic group for certs generation check (kubernetes-sigs#1…
adef492 
…0610)

We take advantage of group_by to create the list of nodes needing new
certs, instead of manually looping inside a Jinja template.

This should make the role more readable and less susceptible to
white space problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@yankay yankay

@MrFreezeex MrFreezeex

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@VannTen @k8s-ci-robot @yankay @MrFreezeex @floryut