-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove crio package configuration #10584
Remove crio package configuration #10584
Conversation
Hi @yckaolalala. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yckaolalala Thank you 👍
/ok-to-test |
name: "{{ item }}" | ||
state: absent | ||
loop: | ||
- /etc/crio/crio.conf.d/01-crio-runc.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the loop instead of just using the filename directly ?
Alternatively, if you want to remove the whole conf dir :
name: "{{ item }}" | |
state: absent | |
loop: | |
- /etc/crio/crio.conf.d/01-crio-runc.conf | |
name: /etc/crio/crio.conf.d/ | |
state: absent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made changes to use the filename directly.
2d3b5a8
to
0a01f05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yckaolalala
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mzaian, yckaolalala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Remove crio package configuration * Remove crio package config directly without loop
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I upgraded my previous ubuntu server with CRI-O installed via apt and encountered the following error:
The root cause is that CRI-O installed via apt creating the '/etc/crio/crio.conf.d/01-crio-runc.conf' file.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: