Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-aws: variable driven ami selection #10520

Conversation

mertcancam
Copy link
Contributor

@mertcancam mertcancam commented Oct 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enhances the AMI selection mechanism by making it variable-driven, enabling users to specify AMI filters directly through variables, thereby improving usability and customization. It aims to provide more flexibility to the users in selecting various AMIs for different distributions without altering the main Terraform files.

  • Variables Driven AMI: Users can now specify ami_name_pattern, ami_owners and ami_virtualization_type through variables, enhancing configurability.
  • Documentation Update: The README is updated to guide users on how to utilize this new variable-driven AMI selection method.

Which issue(s) this PR fixes:
Special notes for reviewers:

The variables.tf file is modified to accept ami_name_pattern, ami_owners and ami_virtualization_type as variables, ensuring that users can specify their preferred AMI without altering main files. This change is backward compatible as it keeps default values in line with the existing hardcoded configuration, ensuring no disruption for users who wish to continue using the existing method.

The README has been updated to reflect these changes and guide users on how to apply them. It provides examples and outlines the step-by-step method for specifying AMI attributes through variables.

Your feedback and insights regarding this implementation and its impact on the user experience would be highly valued.

Does this PR introduce a user-facing change?:

terraform-aws: variable driven ami selection (`ami_name_pattern`/`ami_virtualization_type`/`ami_owners`)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi October 13, 2023 13:10
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @mertcancam!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mertcancam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2023
@mertcancam mertcancam force-pushed the feature/variable-driven-ami-selection branch from a4bc4ad to 2a8c39b Compare October 15, 2023 09:07
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 15, 2023
@mertcancam mertcancam changed the title Feature/variable driven ami selection terraform-aws: variable driven ami selection Oct 15, 2023
@yankay
Copy link
Member

yankay commented Oct 17, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mertcancam Thank you 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mertcancam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 17, 2023
@yankay
Copy link
Member

yankay commented Oct 19, 2023

Thanks @mertcancam
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit e52d708 into kubernetes-sigs:master Oct 19, 2023
59 checks passed
lobiyedKarim1 pushed a commit to lobiyedKarim1/kubespray that referenced this pull request Oct 25, 2023
* modify variables.tf to accept AMI attributes via variables

* update README to guide users on utilizing variable-driven AMI configuration

* fix markdown lint error
lobiyedKarim1 pushed a commit to lobiyedKarim1/kubespray that referenced this pull request Oct 25, 2023
* modify variables.tf to accept AMI attributes via variables

* update README to guide users on utilizing variable-driven AMI configuration

* fix markdown lint error
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
* modify variables.tf to accept AMI attributes via variables

* update README to guide users on utilizing variable-driven AMI configuration

* fix markdown lint error
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
* modify variables.tf to accept AMI attributes via variables

* update README to guide users on utilizing variable-driven AMI configuration

* fix markdown lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants